Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cran errors on r-devel #205

Closed
edzer opened this issue Dec 4, 2022 · 7 comments · Fixed by #207
Closed

cran errors on r-devel #205

edzer opened this issue Dec 4, 2022 · 7 comments · Fixed by #207

Comments

@edzer
Copy link
Member

edzer commented Dec 4, 2022

We see two errors on cran checks for r-devel; this may be transient, but may need attention.

@edzer
Copy link
Member Author

edzer commented Dec 5, 2022

No false positive:

Dear maintainer,

Please see the problems shown on
[<https://cran.r-project.org/web/checks/check_results_s2.html>](https://cran.r-project.org/web/checks/check_results_s2.html).

Please correct before 2022-12-19 to safely retain your package on CRAN.

The CRAN Team

@paleolimbot
Copy link
Collaborator

Yes, I got this from wk, too. Something about as.data.frame(..., optional = TRUE/FALSE) must have changed.

@paleolimbot
Copy link
Collaborator

I'll check this again, but it should be fixed by paleolimbot/wk#166 (plus a patch release of wk to CRAN).

@edzer
Copy link
Member Author

edzer commented Dec 21, 2022

We still see this, and received

Dear maintainer,

Please see the problems shown on
[<https://cran.r-project.org/web/checks/check_results_s2.html>](https://cran.r-project.org/web/checks/check_results_s2.html).

Please correct before 2023-01-09 to safely retain your package on CRAN.

Note that this will be the *final* reminder.

The CRAN Team

or is this because wk hasn't propagated yet?

@paleolimbot
Copy link
Collaborator

That error used to be on wks page and now it is not, however, I should check against the latest r-devel to make sure I didn't miss something

@paleolimbot
Copy link
Collaborator

Actually, a whitespace PR should be able to tell you that from CI. I have two sick kids and one sick wife so you might be able to check that before I can get to it.

@edzer
Copy link
Member Author

edzer commented Dec 21, 2022

check from win-builder - I guess I'll outcomment the offending test, so we can debug later. Good health to the family and you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants