Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PoolBuilder.sizeBetween is always executed twice in ConnectionPool.createConnectionPool. #181

Closed
k163377 opened this issue Oct 10, 2022 · 0 comments
Assignees
Labels
type: bug A general bug
Milestone

Comments

@k163377
Copy link

k163377 commented Oct 10, 2022

.sizeBetween(Math.min(configuration.getMinIdle(), cpuCount), cpuCount)
.idleResourceReuseMruOrder(); // MRU to support eviction of idle
if (maxSize == -1 || initialSize > 0) {
builder.sizeBetween(Math.max(configuration.getMinIdle(), initialSize), maxSize == -1 ? Integer.MAX_VALUE : maxSize);
} else {
builder.sizeBetween(Math.max(configuration.getMinIdle(), initialSize), maxSize);
}

I don't see this causing any particular problem, but I am reporting it because it does not seem to be a very meaningful code.

@mp911de mp911de added the type: bug A general bug label Oct 10, 2022
@mp911de mp911de self-assigned this Oct 10, 2022
@mp911de mp911de added this to the 1.0.0.RELEASE milestone Nov 8, 2022
@mp911de mp911de closed this as completed in aff1141 Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

No branches or pull requests

2 participants