False positive with Style/RedundantParantheses

[eneagoe]

It looks like we have a false positive with this cop:

app/views/layouts/_navigation.slim:34:25: C: [Correctable] Style/RedundantParentheses: Don't use parentheses around a logical expression.

The line in question is

    a.navbar-brand href=(current_customer&.logo_url.presence || root_path)

Without the parantheses we break the template, so they are definitely not redundant.

[r7kamura]

Thanks for reporting, you're absolutely right 👍
I think it would be reasonable to change the default.yml to disable this cop, what do you think?

[eneagoe]

I agree - it would be very difficult to figure out when we can safely apply it.

[r7kamura]

Just released v0.19.0 👌

• https://rubygems.org/gems/slimcop/versions/0.19.0
• https://github.com/r7kamura/slimcop/releases/tag/v0.19.0

[eneagoe]

Beautiful, thank you!

[eneagoe]

Actually there might be another issue - it looks like there's a typo somewhere - it should be Style/RedundantParentheses instead of Style/RedundantParantheses, sorry about that!

[r7kamura]

wow, I'll fix that soon 🤣