Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrolling shutter since #40 #41

Closed
crsantos opened this issue Oct 11, 2018 · 4 comments
Closed

Scrolling shutter since #40 #41

crsantos opened this issue Oct 11, 2018 · 4 comments

Comments

@crsantos
Copy link

Hey 👋
First of all, awesome diff lib.

I started to detect some scrolling shutters when I updated to 0.7.2.

Checking the commits, I see that #40 introduced some setContentOffset calls and I think it may be related to that.

I notice this when I scroll on my UIColllectionView
Sometimes, my scroll is canceled, probably due to a setContentOffset call when a reload is applied when I'm on the middle of a scroll event.

Did anyone notice this on 0.7.2?

I can build sample app to demonstrate if needed.

@iCarambaa
Copy link

I also have a problem with the content offset setting. When deleting an item at the bottom of the collection view the collection view automatically updates the content offset which gets reverted by DifferenceKit. Imho, DifferenceKit should only perform the batch updates but not touch the content offset.

@ra1028
Copy link
Owner

ra1028 commented Oct 26, 2018

@crsantos @iCarambaa
Thank you for your reports.
Agreed.

I will revert its commit to not touching the content offset.
But I'm in state of being bit busy, so please wait until I fixed it ASAP.

@crsantos
Copy link
Author

I wasn't sure if you needed those setContentOffset lines, but if you don't, I can submit PR removing them

@ra1028 ra1028 mentioned this issue Nov 10, 2018
@ra1028
Copy link
Owner

ra1028 commented Nov 10, 2018

This issue is fixed in https://github.com/ra1028/DifferenceKit/releases/tag/0.8.0.
Please reopen this issue if it recurs 👍

@ra1028 ra1028 closed this as completed Nov 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants