-
-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scrolling shutter since #40 #41
Comments
I also have a problem with the content offset setting. When deleting an item at the bottom of the collection view the collection view automatically updates the content offset which gets reverted by DifferenceKit. Imho, DifferenceKit should only perform the batch updates but not touch the content offset. |
@crsantos @iCarambaa I will revert its commit to not touching the content offset. |
I wasn't sure if you needed those |
This issue is fixed in https://github.com/ra1028/DifferenceKit/releases/tag/0.8.0. |
Hey 👋
First of all, awesome diff lib.
I started to detect some scrolling shutters when I updated to
0.7.2
.Checking the commits, I see that #40 introduced some
setContentOffset
calls and I think it may be related to that.I notice this when I scroll on my
UIColllectionView
Sometimes, my scroll is canceled, probably due to a
setContentOffset
call when a reload is applied when I'm on the middle of a scroll event.Did anyone notice this on
0.7.2
?I can build sample app to demonstrate if needed.
The text was updated successfully, but these errors were encountered: