Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill blue devices parameters from SPICE model #786

Closed
ra3xdh opened this issue Jun 24, 2024 · 9 comments · Fixed by #795
Closed

Fill blue devices parameters from SPICE model #786

ra3xdh opened this issue Jun 24, 2024 · 9 comments · Fixed by #795
Assignees
Milestone

Comments

@ra3xdh
Copy link
Owner

ra3xdh commented Jun 24, 2024

This is follow-up for #679. It would be good to add a possibility to convert the SPICE model to unified nonlinear device parameters from the GUI. I propose to add a special button like Fill from SPICE model in the component dialog. The user can press this button and insert the SPICE modelcard .MODEL code. The device properties will be filled automatically. This button should be available for the following devices: Diode, BJT, MOSFET, JFET

@tomhajjar
Copy link

tomhajjar commented Jun 27, 2024

How would you handle parameters not used by ngspice or extra info used by LTspice like "mfg=xxx"? Would you strip them or pass them through? ngspice doesn't like mfg=xxx

Simplified Mosfet "Thermal" models, Rthjc=0.4 Cthj=5e-3?

Another issue is units used. Would you use 1e-9 or 1n as is? Leading 0? 0.01 versus .01

@ra3xdh
Copy link
Owner Author

ra3xdh commented Jun 28, 2024

How would you handle parameters not used by ngspice or extra info used by LTspice like "mfg=xxx"?

The only option is to ignore such model parameters. Qucsconv also ignores them.

Another issue is units used. Would you use 1e-9 or 1n as is? Leading 0? 0.01 versus .01

It is possible to apply the units conversion. Qucs-S parser accepts both notation. It should be possible to implement a checkbox like Convert number notaiton in the model import dialog.

@ra3xdh
Copy link
Owner Author

ra3xdh commented Jul 3, 2024

The proposed feature implemented by #795

@ra3xdh ra3xdh added this to the 24.3.0 milestone Jul 3, 2024
@ra3xdh ra3xdh self-assigned this Jul 3, 2024
@ra3xdh
Copy link
Owner Author

ra3xdh commented Jul 4, 2024

Here is a new look of the component properties dialog and new SPICE model import window.
image
image

@ra3xdh
Copy link
Owner Author

ra3xdh commented Jul 4, 2024

The feature implemented by #795. Closing this.

@tomhajjar
Copy link

If leading zero is missing does it add it?

@ra3xdh
Copy link
Owner Author

ra3xdh commented Jul 4, 2024

No, it currently cannot handle missing leading zero. I am not sure if Ngspice allow such notation. I may add a patch implementing this conversion.

@tomhajjar
Copy link

Another issue was some Spice models using the Greek µ instead of u. ngspice doesn't like µ

@ra3xdh
Copy link
Owner Author

ra3xdh commented Jul 4, 2024

Another issue was some Spice models using the Greek µ instead of u. ngspice doesn't like µ

I cannot do anything with this. Ngspice doesn't support Unicode.

@ra3xdh ra3xdh mentioned this issue Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants