Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add activity_status attribute to ConsumerDetails #470

Closed
mikymigs opened this issue Jul 2, 2024 · 6 comments
Closed

Add activity_status attribute to ConsumerDetails #470

mikymigs opened this issue Jul 2, 2024 · 6 comments
Milestone

Comments

@mikymigs
Copy link

mikymigs commented Jul 2, 2024

Is your feature request related to a problem? Please describe.

ConsumerDetails class does not map the activity_status attribute of the /api/consumers response.

Describe the solution you'd like

The /api/consumers call provides a list of consumers. Each consumer object in the response has an activity_status attribute that can have values such as waiting or single_active. I would like it if you could add this field to the ConsumerDetails class.

Other fields are missing such as ack_required or consumer_timeout. I don't necessarily need those but I don't see any reason why the lib should limit the information available via the management API (might as well build our own lib in this case...)

Thanks a lot,

Describe alternatives you've considered

Using the active flag but it doesn't provide enough details.

Additional context

No response

@michaelklishin
Copy link
Member

@mikymigs you are welcome to contribute it. It should be a matter of a Jackson mapping change.

Adding a test should be reasonably straightforward, too, but if it's a matter of adding one field to an existing domain class, I'd personally accept a PR without any tests.

@mikymigs
Copy link
Author

mikymigs commented Jul 4, 2024

Thank you for your reply @michaelklishin
Would be happy to contribute. I will try to propose a PR when I find the time :)

@mikymigs
Copy link
Author

mikymigs commented Jul 6, 2024

Hello @michaelklishin,
Tried to push a branch it seems I don't have access rights. Can you authorize me to push branches and create PRs ?

Thanks

@michaelklishin
Copy link
Member

michaelklishin commented Jul 6, 2024

@mikymigs of course I won't, that's way unreasonable of an ask from a first time contributor.

You need to fork this repo, push a branch to your own fork and then submit a pull request.

@mikymigs
Copy link
Author

mikymigs commented Jul 6, 2024

Sorry, new to the github practices. Will go through a fork.

acogoluegnes added a commit that referenced this issue Jul 8, 2024
…utes-to-consumer-details

Add missing attributes to channel and consumer details
@acogoluegnes acogoluegnes added this to the 5.3.0 milestone Jul 8, 2024
@acogoluegnes
Copy link
Contributor

Fixed in #471.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants