-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add activity_status attribute to ConsumerDetails #470
Comments
@mikymigs you are welcome to contribute it. It should be a matter of a Jackson mapping change. Adding a test should be reasonably straightforward, too, but if it's a matter of adding one field to an existing domain class, I'd personally accept a PR without any tests. |
Thank you for your reply @michaelklishin |
Hello @michaelklishin, Thanks |
@mikymigs of course I won't, that's way unreasonable of an ask from a first time contributor. You need to fork this repo, push a branch to your own fork and then submit a pull request. |
Sorry, new to the github practices. Will go through a fork. |
…utes-to-consumer-details Add missing attributes to channel and consumer details
Fixed in #471. |
Is your feature request related to a problem? Please describe.
ConsumerDetails
class does not map the activity_status attribute of the/api/consumers
response.Describe the solution you'd like
The
/api/consumers
call provides a list of consumers. Each consumer object in the response has anactivity_status
attribute that can have values such aswaiting
orsingle_active
. I would like it if you could add this field to theConsumerDetails
class.Other fields are missing such as
ack_required
orconsumer_timeout
. I don't necessarily need those but I don't see any reason why the lib should limit the information available via the management API (might as well build our own lib in this case...)Thanks a lot,
Describe alternatives you've considered
Using the
active
flag but it doesn't provide enough details.Additional context
No response
The text was updated successfully, but these errors were encountered: