Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove zeroed sockets_used/sockets_total #466

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

lhoguin
Copy link
Contributor

@lhoguin lhoguin commented Jun 24, 2024

Values are zeroed following partial removal of the FHC.

FYI I don't know what I'm doing. This is Java or something. Let's see if it works!

@lhoguin
Copy link
Contributor Author

lhoguin commented Jun 24, 2024

@acogoluegnes Can you help? Thanks!

Values are zeroed following partial removal of the FHC.
@michaelklishin
Copy link
Member

It was a matter of removing a couple more methods in NodeInfo.java.

@michaelklishin michaelklishin merged commit 63269b9 into main Jun 24, 2024
2 checks passed
@michaelklishin michaelklishin deleted the loic-remove-zeroed-stats branch June 24, 2024 10:18
@lhoguin
Copy link
Contributor Author

lhoguin commented Jun 24, 2024

Huh. My bad, I thought I had covered them all. Thanks for the fix!

@acogoluegnes
Copy link
Contributor

acogoluegnes commented Jun 24, 2024

See rabbitmq/rabbitmq-server#11436.

These metrics will always return 0 in RabbitMQ 4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants