Remove most of the fd related FHC code #11436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelklishin
force-pushed
the
loic-remove-fhc
branch
from
d19e9f2
to
71f324c
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
essen
force-pushed
the
loic-remove-fhc
branch
5 times, most recently
from
85475a6
to
7ca27e2
Compare
|
Next steps are:
|
essen
force-pushed
the
loic-remove-fhc
branch
2 times, most recently
from
58f9d4b
to
b720a28
Compare
lhoguin
commented
Jun 18, 2024
essen
force-pushed
the
loic-remove-fhc
branch
2 times, most recently
from
085d220
to
6ab94d3
Compare
|
Rebased, and sent a PR to the few clients noted previously. This can be merged when green. |
Stats were not removed, including management UI stats relating to FDs. Web-MQTT and Web-STOMP configuration relating to FHC were not removed. The file_handle_cache itself must be kept until we remove CQv1.
Part of the removal of file_handle_cache. The Prometheus endpoint was updated but the Grafana dashboard was not. The FD stats are using the system's state rather than file_handle_cache so there's no need to remove them.
They are no longer used. This removes a couple file_handle_cache:info/1 calls. We are not removing them from the HTTP API to avoid breaking things unintentionally.
The stats were not removed from management agent, instead they are hardcoded to zero in the agent itself.
The message has been tweaked; it isn't about FHC or queues but about system limits only. The ulimit() function can later be moved out of FHC when FHC gets fully removed.
The FD limits are still valuable. The FD used will still show some information during CQv1 upgrade to v2 so it is kept for now. But in the future it will have to be reworked to query the system, or be removed.
michaelklishin
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stats were not removed YET, including management UI stats relating to FDs.
Web-MQTT and Web-STOMP configuration relating to FHC were not removed.
The file_handle_cache itself must be kept until we remove CQv1.