Add feature flag warning

Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
rabbitmq · Sep 19, 2023 · 7111227 · 7111227
1 parent 2b72a3f
commit 7111227
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 7 deletions.
diff --git a/RabbitMQ.Stream.Client/Consts.cs b/RabbitMQ.Stream.Client/Consts.cs
@@ -20,6 +20,10 @@ internal static class Consts
         internal const string SubscriptionPropertyFilterPrefix = "filter.";
         internal const string SubscriptionPropertyMatchUnfiltered = "match-unfiltered";
 
+        internal const string FilterNotSupported = "Broker does not support filtering. " +
+                                                   "You need RabbitMQ 3.13.0 or later and" +
+                                                   "the stream_filtering feature flag enabled.";
+
         internal static int RandomShort()
         {
             return Random.Shared.Next(500, 1500);

diff --git a/RabbitMQ.Stream.Client/RawConsumer.cs b/RabbitMQ.Stream.Client/RawConsumer.cs
@@ -82,9 +82,7 @@ internal void Validate()
 
             if (IsFiltering && !AvailableFeaturesSingleton.Instance.PublishFilter)
             {
-                throw new UnsupportedOperationException("Broker does not support filtering. You need " +
-                                                        "RabbitMQ 3.13.0 or later and " +
-                                                        "the stream_filtering feature flag enabled.");
+                throw new UnsupportedOperationException(Consts.FilterNotSupported);
             }
 
             switch (ConsumerFilter)

diff --git a/RabbitMQ.Stream.Client/RawProducer.cs b/RabbitMQ.Stream.Client/RawProducer.cs
@@ -44,9 +44,7 @@ internal void Validate()
         {
             if (Filter is { FilterValue: not null } && !AvailableFeaturesSingleton.Instance.PublishFilter)
             {
-                throw new UnsupportedOperationException("Broker does not support filtering. " +
-                                                        "You need RabbitMQ 3.13.0 or later and" +
-                                                        "the stream_filtering feature flag enabled.");
+                throw new UnsupportedOperationException(Consts.FilterNotSupported);
             }
         }
     }

diff --git a/docs/StreamFilter/StreamFilter/README.md b/docs/StreamFilter/StreamFilter/README.md
@@ -1,8 +1,12 @@
 Server Side Filter Example
 --------------------------
 
+WARNING: Filtering requires *RabbitMQ 3.13* or more and the stream_filter feature flag enabled.
+
+
 This example shows how to use the server side filter to filter the data on the server side.
 
+
 ### Running the Producer 
 
 ```

diff --git a/docs/asciidoc/advanced-topics.adoc b/docs/asciidoc/advanced-topics.adoc
@@ -4,7 +4,7 @@
 
 ==== Filtering
 
-WARNING: Filtering requires *RabbitMQ 3.13* or more.
+WARNING: Filtering requires *RabbitMQ 3.13* or more and the stream_filter feature flag enabled.
 
 RabbitMQ Stream provides a server-side filtering feature that avoids reading all the messages of a stream and filtering only on the client side.
 This helps to save network bandwidth when a consuming application needs only a subset of messages, e.g. the messages from a given geographical region.