Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Tailwind classes of parent element don't get applied to Button #522

Closed
kuchiPie opened this issue Nov 3, 2024 · 4 comments
Closed

Comments

@kuchiPie
Copy link

kuchiPie commented Nov 3, 2024

Description

Bit unsure if it is a bug or an enhancement.

I noticed that tailwind classes don't get applied to the button the way it works on other libraries. The buttons inside the table are not left-aligned even after className="text-right" is applied to it's parent element.

ShadCN:
image
RadUI:
image

Related Tickets & Documents

e.g., Relates to [#4165]

Mobile & Desktop Screenshots/Recordings

If applicable, add screenshots/recordings that show:

  • The bug in action
  • Any error messages
  • The expected behavior (if possible)

[optional]What gif best describes this PR or how it makes you feel?

@kotAPI
Copy link
Collaborator

kotAPI commented Nov 3, 2024

Thanks for the issue @kuchiPie, currently the display property on the button is set to flex on the button, we'll change it to inline-flex to fix this behavior so it behaves more accurately like a native button

@GoldGroove06, an easy fix if you want to take it up 🥇

This was referenced Nov 3, 2024
@GoldGroove06
Copy link
Contributor

On to it

@kotAPI
Copy link
Collaborator

kotAPI commented Nov 3, 2024

Fixed in #534

should be available once we update the npm package

We're currently working on #536 to restore the build pipelines

@kotAPI
Copy link
Collaborator

kotAPI commented Nov 15, 2024

This should be fixed on 0.0.25 @kuchiPie

@kotAPI kotAPI closed this as completed Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants