Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New 'continuous' CI release breaks version/release tracking #17598

Closed
Nicceboy opened this issue Sep 5, 2020 · 7 comments · Fixed by #17603
Closed

New 'continuous' CI release breaks version/release tracking #17598

Nicceboy opened this issue Sep 5, 2020 · 7 comments · Fixed by #17603
Assignees

Comments

@Nicceboy
Copy link

Nicceboy commented Sep 5, 2020

Is your feature request related to a problem? Please describe.

New "continuous" CI release breaks release and version tracking through GitHub API. Release and version tracking is useful when automating tool packaging for third-party providers and keeping it up-to-date with official releases instead of master branch.
Example:

curl https://api.github.com/repos/radareorg/radare2/releases/latest

Returns release with tag 'continuous', which is not useful and will be always the same. Instead, it would be useful to see the latest real release, in this case the one with tag 4.5.1.

Describe the solution you'd like

Continuous release could be marked as 'pre-release`. Then it is not included, when making the request to see the latest actual release.

@karliss
Copy link
Contributor

karliss commented Sep 5, 2020

It was discussed a few times that current approach isn't great. A better solution might be running those builds as github actions and uploading results as artifacts without polluting release list and notifications, but someone needs to do it. So far no one has been sufficiently annoyed to do the required work and make a PR.

Marking as pre-release sounds like reasonable and simple improvement until a better solution is done.

@ret2libc
Copy link
Contributor

ret2libc commented Sep 6, 2020

What I also wonder is whether those .Deb continuous files are really used/downloaded by anyone. Unfortunately I don't think there is a clear way to know...

@karliss
Copy link
Contributor

karliss commented Sep 6, 2020

Github release counts are tracked. Not sure where it's displayed in UI but It is available using API. An easy way of viewing it is with this website https://somsubhra.com/github-release-stats/?username=radareorg&repository=radare2 . One problem is that each time new continuous release is uploaded numbers are reset.

@ret2libc ret2libc self-assigned this Sep 6, 2020
@ret2libc
Copy link
Contributor

ret2libc commented Sep 6, 2020

Ok, I'm assigning this to me. The task would be to create a Github workflow that will create artifacts on each commit to master, as @karliss suggested. So we can disable the push from the travis job. @trufae ok with this? Asking because the script is uploading those artifacts with your account.

@ret2libc
Copy link
Contributor

ret2libc commented Sep 7, 2020

Unfortunately there is this "small" problem with GitHub artifacts actions/upload-artifact#51 :( This makes them quite useless imo. If we want to keep support continuous build (which I still question...) we may have to do a pre-release.

@ret2libc
Copy link
Contributor

ret2libc commented Sep 8, 2020

Ok, PR merged. Let's see how it goes. Now they should be marked as pre-releases. (I'd still be very happy to just remove those "continuous build" pre-releases :D)

@Nicceboy
Copy link
Author

Thank you. Seems to be working well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants