Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: windows double keypress issue #48

Merged
merged 5 commits into from
Oct 24, 2023
Merged

fix: windows double keypress issue #48

merged 5 commits into from
Oct 24, 2023

Conversation

0Ky
Copy link
Contributor

@0Ky 0Ky commented Oct 23, 2023 •
edited
Loading

  • Addressed a bug on Windows where each key press event is registered twice. A fix has been implemented by checking for KeyEventKind::Press before processing the key press.
  • Added a Windows-GNU target to the release

This PR closes issue #39 and #37.

Test result: ok. 20 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.05s

@0Ky
fix(paths): add os specific directory handling for windows
356b4b1 
Adjusted the path generation in `get_results_dir_path`, `handle_main_command`, and `setup_terminal` to account for Windows-specific local config directory conventions using the `cfg!` macro.
@0Ky
Merge remote-tracking branch 'upstream/main' into fix/windows-directo…
c913c0d 
…ry-handling
@0Ky
fix: windows double keypress issue
369c08a
@0Ky
style(fmt): apply cargo fmt
078c65c
@0Ky
feat(workflows): enable windows-gnu target release
3af2f79
radlinskii
radlinskii approved these changes Oct 24, 2023
View reviewed changes
Copy link
Owner

@radlinskii radlinskii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully tested it on MacOS too, thx!

@radlinskii radlinskii merged commit 2792331 into radlinskii:main Oct 24, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radlinskii radlinskii radlinskii approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0Ky @radlinskii