Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config file should be the same format as xboxdrv #65

Open
multimeric opened this issue Oct 14, 2018 · 0 comments
Open

Config file should be the same format as xboxdrv #65

multimeric opened this issue Oct 14, 2018 · 0 comments

Comments

@multimeric
Copy link

multimeric commented Oct 14, 2018

It seems that the ubuntu_xboxdrv config file (this one) is a custom format, that lets you specify FORCE_FEEDBACK, TRIGGER_AS_BUTTON, and MIMIC_XPAD. However, if you want to use any option other than these 3, you have to specify it as an xboxdrv flag, e.g. XBOXDRV_OPTIONS="--dpad-as-button".

I don't think it makes sense to have a custom config file, especially one that only implements a small subset of options, when xboxdrv already has a well documented config file: https://pingus.seul.org/~grumbel/xboxdrv/xboxdrv.html#idp65351024.

I think ubuntu_xboxdrv should use the original xboxdrv config file, and install it into /etc/default/xboxdrv, and then run xboxdrv with -c /etc/default/xboxdrv. This would be helpful firstly because the xboxdrv config file is much more feature complete and well-documented. Making this change would better unify the two projects, and allow people to share configs, if they're using xboxdrv or ubuntu_xboxdrv. It would also mean that people who end up on the xboxdrv manual page aren't confused as to which config format they should be using.

I'm happy to write a PR to this effect, but I'd like to check if everyone thinks this would be a reasonable change.

@multimeric multimeric changed the title Config file format Config file should be the same format as xboxdrv Oct 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant