From 01bf7402401dc5e38b3172628dfb1e4491e52b84 Mon Sep 17 00:00:00 2001 From: Greg Hogan Date: Wed, 13 May 2020 09:31:20 -0700 Subject: [PATCH] remove 0x1BE checksum test --- tests/safety/test_honda.py | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/tests/safety/test_honda.py b/tests/safety/test_honda.py index 1597495da9abb5..e053e4e586922f 100755 --- a/tests/safety/test_honda.py +++ b/tests/safety/test_honda.py @@ -274,14 +274,15 @@ def _alt_brake_msg(self, brake): self.__class__.cnt_brake += 1 return self.packer.make_can_msg_panda("BRAKE_MODULE", self.PT_BUS, values) - def test_alt_brake_rx_hook(self): - self.safety.set_honda_alt_brake_msg(1) - self.safety.set_controls_allowed(1) - to_push = self._alt_brake_msg(0) - self.assertTrue(self._rx(to_push)) - to_push[0].RDLR = to_push[0].RDLR & 0xFFF0FFFF # invalidate checksum - self.assertFalse(self._rx(to_push)) - self.assertFalse(self.safety.get_controls_allowed()) + # TODO: add back in once alternative brake checksum/counter validation is added + # def test_alt_brake_rx_hook(self): + # self.safety.set_honda_alt_brake_msg(1) + # self.safety.set_controls_allowed(1) + # to_push = self._alt_brake_msg(0) + # self.assertTrue(self._rx(to_push)) + # to_push[0].RDLR = to_push[0].RDLR & 0xFFF0FFFF # invalidate checksum + # self.assertFalse(self._rx(to_push)) + # self.assertFalse(self.safety.get_controls_allowed()) def test_alt_disengage_on_brake(self): self.safety.set_honda_alt_brake_msg(1)