From 237829617c098bc18c028fb8130ad672b8e0ffb7 Mon Sep 17 00:00:00 2001 From: GitHub Actions Bot <> Date: Fri, 25 Oct 2024 22:57:14 +0200 Subject: [PATCH] bring back pr template, use cache properly in tests Signed-off-by: GitHub Actions Bot <> --- .github/PULL_REQUEST_TEMPLATE.md | 8 ++++++++ Makefile | 8 +++++++- 2 files changed, 15 insertions(+), 1 deletion(-) create mode 100644 .github/PULL_REQUEST_TEMPLATE.md diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 0000000..3c78b18 --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,8 @@ +### Contributor's Note + + + +- [ ] I have added or updated documentation in `/docs` for any user-facing features or additions. \ No newline at end of file diff --git a/Makefile b/Makefile index 00aac89..47cb1c9 100644 --- a/Makefile +++ b/Makefile @@ -1,6 +1,12 @@ # to run tests with arm64 see https://docs.docker.com/build/building/multi-platform/ export OGION_ARCH ?= amd64 +ifdef CI +BUILD := +else +BUILD := "--build" +endif + .PHONY: docker_setup_up docker_setup_up: docker compose -f docker/docker-compose.yml up -d gcs minio azurite @@ -14,7 +20,7 @@ docker_setup_down: .PHONY: unit_tests unit_tests: $(MAKE) docker_setup_up - docker compose -f docker/docker-compose.yml run --rm --build ogion_unit_tests + docker compose -f docker/docker-compose.yml run --rm $(BUILD) ogion_unit_tests .PHONY: acceptance_tests acceptance_tests: