New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hardcode settlement timeout #1550

Closed

4 tasks done

palango opened this issue Nov 8, 2021 · 0 comments · Fixed by #1557

Closed

4 tasks done

Hardcode settlement timeout #1550

palango opened this issue Nov 8, 2021 · 0 comments · Fixed by #1557

Assignees

Contributor

palango commented Nov 8, 2021 •

edited by netcriptus

Loading

After discussion at the retreat we want to get rid of the configurable settle timeouts at channel creation.

This issue tracks the removal of this option and dependent cleanups.

Remove settle_timeout parameter in TokenNetwork.openChannel and TokenNetwork.openChannelWithDeposit (https://github.com/raiden-network/raiden-contracts/blob/master/raiden_contracts/data/source/raiden/TokenNetwork.sol#L265)
Remove _settlement_timeout_min and _settlement_timeout_max parameters in TokenNetwork constructor (https://github.com/raiden-network/raiden-contracts/blob/master/raiden_contracts/data/source/raiden/TokenNetwork.sol#L220)
Remove _settlement_timeout_min and _settlement_timeout_max parameters in TokenNetworkRegistry constructor (https://github.com/raiden-network/raiden-contracts/blob/master/raiden_contracts/data/source/raiden/TokenNetworkRegistry.sol#L41)
Fix/cleanup tests

The text was updated successfully, but these errors were encountered:

netcriptus self-assigned this

netcriptus mentioned this issue

Remove configurable timeout range #1557

Merged

netcriptus linked a pull request

that will close this issue

Remove configurable timeout range #1557

Merged

netcriptus closed this as completed

karlb mentioned this issue

Add off-chain settlement period negotiation raiden-network/raiden#864

Closed

2 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment