You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As the timeout value has changed from block numbers to time in seconds, this has become a challenge for (end-to-end) tests. The current constant value are 25min. That is way too long. In the past we could just mine a couple of blocks. But manipulating pure time is not a good non unit tests.
Therefore it should be possible to set the withdraw timeout in the constructor of the User Deposit contract. This is the same strategy as we already do for the Token Network and Token Registry contract. The deployment tools will then contain the current constant value as the default for the new optional argument.
The text was updated successfully, but these errors were encountered:
As the timeout value has changed from block numbers to time in seconds, this has become a challenge for (end-to-end) tests. The current constant value are 25min. That is way too long. In the past we could just mine a couple of blocks. But manipulating pure time is not a good non unit tests.
Therefore it should be possible to set the withdraw timeout in the constructor of the User Deposit contract. This is the same strategy as we already do for the Token Network and Token Registry contract. The deployment tools will then contain the current constant value as the default for the new optional argument.
The text was updated successfully, but these errors were encountered: