Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable cooperativeSettle #399

Closed
loredanacirstea opened this issue Jan 7, 2019 · 1 comment
Closed

Reenable cooperativeSettle #399

loredanacirstea opened this issue Jan 7, 2019 · 1 comment
Labels
enhancement New feature or request Needs redeployment The issue/PR results in a breaking change in the precompiled data in `contracts.json` ->redeployment P2 demanded by somebody

Comments

@loredanacirstea
Copy link
Contributor

We commented out cooperativeSettle in #270

These should be changed back when re-enabling cooperative settle:

Contracts

Test contracts

  • uncomment recoverAddressFromCooperativeSettleSignaturePublic recoverAddressFromCooperativeSettleSignaturePublic

Tests

@loredanacirstea loredanacirstea added the Needs redeployment The issue/PR results in a breaking change in the precompiled data in `contracts.json` ->redeployment label Jan 9, 2019
@pirapira pirapira added enhancement New feature or request P4: good_to_have labels Feb 4, 2019
@pirapira pirapira added P2 demanded by somebody and removed P4: good_to_have backlog labels Apr 15, 2019
@pirapira pirapira changed the title Reenable cooperativeSettle Reenable cooperativeSettle (wait till client implements withdraw) Apr 16, 2019
@pirapira pirapira changed the title Reenable cooperativeSettle (wait till client implements withdraw) Reenable cooperativeSettle Sep 10, 2019
@hackaugusto
Copy link
Contributor

Note, withdraw was re-enabled by #711 . coop seetle is redundant with withdraw, since we can implement it with two withdraws done by a proxy smart contract. This is not really necessary anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Needs redeployment The issue/PR results in a breaking change in the precompiled data in `contracts.json` ->redeployment P2 demanded by somebody
Projects
None yet
Development

No branches or pull requests

3 participants