Use <<~ (squiggly heredoc) to address warning: literal string will be frozen in the future
#544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skipkayhil
approved these changes
Oct 23, 2024
… be frozen in the future` This commit addresses the `warning: literal string will be frozen in the future` ```$ ruby -v ruby 3.4.0dev (2024-10-21T16:48:53Z master 5131fb5dbe) +PRISM [x86_64-linux] $ RUBYOPT="--debug-frozen-string-literal" bundle exec rake test TEST=test/test_quiet_assets.rb ``` - Warnings addressed by this commit ```ruby /path/to/sprockets-rails/lib/sprockets/rails/quiet_assets.rb:24: warning: literal string will be frozen in the future /path/to/sprockets-rails/lib/sprockets/rails/quiet_assets.rb:23: info: the string was created here ``` - Sprockets Rails requires Ruby 2.5 that supports `<<~` (squiggly heredoc) introduced since Ruby 2.3. https://www.ruby-lang.org/en/news/2015/12/25/ruby-2-3-0-released/ https://github.com/ruby/ruby/blob/d40ea2afa6ff5a6e5befcf342fb7b6dc58796b20/NEWS?plain=1#L53-L57 ruby/ruby#11893 - `--debug-frozen-string-literal` option has been introduced via ruby/ruby#11893
yahonda
force-pushed
the
use_squiggly_herdoc
branch
from
064b0b2 to
c301515
Compare
yahonda
changed the title
<<~ (squiggly heredoc) to address `warning: literal string will be frozen in the future<<~ (squiggly heredoc) to address warning: literal string will be frozen in the future`
yahonda
changed the title
<<~ (squiggly heredoc) to address warning: literal string will be frozen in the future`<<~ (squiggly heredoc) to address warning: literal string will be frozen in the future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses the
warning: literal string will be frozen in the futureagainst Ruby 3.4.0dev<<~(squiggly heredoc) introduced since Ruby 2.3.https://www.ruby-lang.org/en/news/2015/12/25/ruby-2-3-0-released/ https://github.com/ruby/ruby/blob/d40ea2afa6ff5a6e5befcf342fb7b6dc58796b20/NEWS?plain=1#L53-L57 ruby/ruby#11893
--debug-frozen-string-literaloption has been introduced via Show where mutated chilled strings were allocated ruby/ruby#11893