Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add whitelist/black list of IP addresses that can be connected to. #7

Open
woodsaj opened this issue Sep 15, 2015 · 3 comments
Open

Comments

@woodsaj
Copy link
Contributor

woodsaj commented Sep 15, 2015

We need a mechanism to prevent malicious use of the probe service. For example the probes will often be running within customers own networks, but connected to the outside world. We need to ensure that users cant craft nasty checks that could be used to attach internal servers that the prove server may have access to.

The basic thought here is to proved a way to set a whitelist and blacklist of IP address/ranges.
When checks are executing, they should consult these lists to determine if they can perform the check on the target IP address.

@Dieterbe
Copy link
Contributor

we may want to make the main org an exception to this restriction.
because using a tool like env-load you typically want to use a dummy local endpoint (ideally localhost on each collector) for efficiency reasons to aim your large workload on.

@woodsaj
Copy link
Contributor Author

woodsaj commented Sep 16, 2015

i would rather not complicate the entire process for such a single rare use case.

If you want to do load testing, then dont use an IP that is blacklisted. A simple solution would be to just configure a dummy interface on each of the collectors with a non-blacklisted ip.

ifconfig eth0:1 192.168.1.1 netmask 255.255.255.255

@Dieterbe
Copy link
Contributor

ok that should work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants