Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove setup script, download libs when building #65

Closed
rainyl opened this issue May 28, 2024 · 3 comments · Fixed by #66
Closed

Remove setup script, download libs when building #65

rainyl opened this issue May 28, 2024 · 3 comments · Fixed by #66
Labels
enhancement New feature or request

Comments

@rainyl
Copy link
Owner

rainyl commented May 28, 2024

Is your feature request related to a problem? Please describe.

since native assets are experimental, and i do find that the setup command hard to use for most developers, dont you think we should make the cmake download the libs when launching or compiling the app? if you dont mind i can work on it, and leave this pr if other people request it

For windows and linux it is reasonable, but android, ios and macos doesn't use cmake, I am wondering how to make flutter download the libs automatically? writing separate download scripts for gradlea and pod?

for android yes gradle
in general we can check this https://github.com/media-kit/media-kit/tree/main/libs in media_kit libs get downloaded on app build

Making sense, I will open a new issue to track it, but I am not familiar with macos and ios development, if you are interest in it, PRs are welcome!

#63 (comment)

@rainyl rainyl added the enhancement New feature or request label May 28, 2024
@abdelaziz-mahdy
Copy link
Contributor

Just a question, would you like the libs each to be their own lib? Like media_kit or in the same package ?

@rainyl
Copy link
Owner Author

rainyl commented May 28, 2024

I prefer a universal one, so please just keep the current structure. 😄

@abdelaziz-mahdy abdelaziz-mahdy mentioned this issue May 28, 2024
15 tasks
@rainyl rainyl linked a pull request May 29, 2024 that will close this issue
15 tasks
@rainyl
Copy link
Owner Author

rainyl commented May 29, 2024

@abdelaziz-mahdy #66 has been merged, I am going to close this issue, thanks for your contributions~ 😄

@rainyl rainyl closed this as completed May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants