Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JsonIgnore missing on SignKeyRequest properties #346

Closed
lukeocamden opened this issue Mar 14, 2024 · 0 comments
Closed

JsonIgnore missing on SignKeyRequest properties #346

lukeocamden opened this issue Mar 14, 2024 · 0 comments
Assignees
Milestone

Comments

@lukeocamden
Copy link

Describe the bug
Serialized SigninKeyRequest can be invalid due to missing [JsonIgnore(Condition = JsonIgnoreCondition.WhenWritingNull)]

VaultSharp Version
1.13.0.1

Vault Version
1.13.2+ent

Does this work with Vault CLI?
Yes

Sample Code Snippet

var signedKey = await vaultClient.V1.Secrets.SSH.SignKeyAsync(principal,
    new SignKeyRequest
    {
        ValidPrincipals = principal,
        PublicKey = publicKey,
    }, "ssh/whatever");

Exception Details/Stack Trace/Error Message
Permission denied from server.

Any additional info
Hello! In 11af98d you fixed lots of properties so null values would not be sent to Vault API (fixing #312). However I think SignKeyRequest.cs was missed from this change. Is it easy to fix?

@rajanadar rajanadar self-assigned this Sep 8, 2024
@rajanadar rajanadar added this to the 1.17.5 milestone Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants