Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI: Orphaned gates after an ancestor-gate's formula & type manipulations #279

Open
bavovanachte opened this issue Sep 11, 2018 · 7 comments

Comments

@bavovanachte
Copy link
Contributor

I've had an issue a couple of times where I accidentally orphaned some events (or subtrees). The tool happily allowed me to save the file, but then when I tried to reopen it, the tool refused to do so claiming that there were multiple top events.

I managed to fix these issues by manually fiddling in the xml until it worked, but the situation shouldn't occur (or the tool should allow the user to fix it in the gui itself)

@rakhimov
Copy link
Owner

@bavovanachte Are you using the dev version or the master?
The dev GUI hasn't yet been updated with the add-remove API.

@rakhimov
Copy link
Owner

Could you provide exact steps that led to orphaned gates?

@rakhimov
Copy link
Owner

Note this issue will become irrelevant if #209 is done first.

@rakhimov
Copy link
Owner

I think I missed this in the original implementation,
so it is present in the master branch as well.
Some cases of orphaned gates:

  • changing a parent gate formula
  • changing a parent node type (gate -> basic, gate -> house)

@rakhimov rakhimov changed the title GUI: warn about orphaned elements when saving GUI: Orphaned gates after an ancestor-gate's formula & type manipulations Sep 12, 2018
@bavovanachte
Copy link
Contributor Author

Sorry for the delay. I'm using the version installed from apt now (0.16.2).

Would you like me to retest with a version on master?

@bavovanachte
Copy link
Contributor Author

Will try to reproduce the issue later today, and provide a minimal example to reproduce

@rakhimov
Copy link
Owner

Sorry for the delay. I'm using the version installed from apt now (0.16.2).

Would you like me to retest with a version on master?

No need @bavovanachte . I confirmed the bug (or missing feature?) in all GUI releases.
This is a design issue that needs to be properly solved by #209.
I'd appreciate your tests once the feature is implemented. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants