-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Startup time #74
Comments
This issue has not yet been reported, will need some investigation. |
Just bumping this issue with the results of my profiler:
|
I think this performance hit on startup (even when the scheme isn't active) is due to the use of functions to define the colors vs. hard-coded values. It would be a non-trivial effort to rewrite those (I think this was built from the base16 generator originally), but that might be a contributor. h/t @devinrm for the suggestion. |
I should clarify that I don't think this is easy, and it might reduce the comprehensiveness of the scheme, limiting the size of the group that can use it. |
@geoffharcourt Thx for your explanation. I just made a hard-coded fork of vim-one and the startup time improves dramatically. # the original one
❯ vim-profiler.py -r 10 nvim
=====================================
Top 10 plugins slowing nvim's startup
=====================================
1 170.621 vim-one
2 6.274 vim-airline
3 4.038 vim-polyglot
4 3.496 coc.nvim
5 2.645 colorizer
6 2.413 vim-textobj-xmlattr
7 2.313 vim-textobj-comment
8 1.795 vim-sensible
9 1.664 vim-textobj-line
10 1.341 ctrlp.vim
=====================================
# the hard-coded
❯ vim-profiler.py -r 10 nvim
=====================================
Top 10 plugins slowing nvim's startup
=====================================
1 11.172 vim-one
2 6.650 vim-airline
3 3.960 vim-polyglot
4 3.579 coc.nvim
5 2.830 colorizer
6 2.405 vim-textobj-comment
7 2.372 vim-textobj-xmlattr
8 1.732 vim-sensible
9 1.724 vim-textobj-line
10 1.430 ctrlp.vim
===================================== Italic setting |
@laggardkernel did you have a script or programmatic way to do this? |
@geoffharcourt No, not yet. I used command As far as I know, it's the most simple way to convert the original project to a hard-coded color scheme. Maybe I'll restructure the code later. Haven't made up my mind. |
Thanks for your patience, thanks to @laggardkernel and the use of better approximation, this issue should now be fixed by the latest commit to master. |
@rakr Thank God you're back. There's another optimization I borrowed from vim theme gruvbox that reuses |
This plugin significantly adds to my vim / nvim startup time by contributing
328ms
to it. Is this a known issue / is there any way to improve this startup time?Thanks for any help and also thanks for this wonderful plugin - it was the first vim plugin I used back when I switched from Atom! 👍
The text was updated successfully, but these errors were encountered: