Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not compile without serde feature #214

Open
DragonDev1906 opened this issue Aug 16, 2023 · 3 comments
Open

Does not compile without serde feature #214

DragonDev1906 opened this issue Aug 16, 2023 · 3 comments

Comments

@DragonDev1906
Copy link

There is a PR that tried to fix this, but it was not merged yet and I don't know if it is still current: #191

On the current main branch ethereum-consensus does not compile without the serde feature due to the reason stated in #191:

cargo check --no-default-features
@DragonDev1906 DragonDev1906 changed the title Does not compile without `serde´ feature Does not compile without serde feature Aug 16, 2023
@ralexstokes
Copy link
Owner

thanks for raising this, I think the changes in #191 make sense but also make the code more dense than it already is, so if anything I'd possibly even just support removing the serde feature and having the library support it by default

are you doing something where this is blocking you?

@DragonDev1906
Copy link
Author

are you doing something where this is blocking you?

No, I'm likely going to need serde anyways. Even if I don't the main downside is longer compile times.
For me --no-default-features -F serde is sufficient.

I just wanted to mention that the serde feature doesn't work as expected.

@ralexstokes
Copy link
Owner

great, thanks for the message :)

I'll leave this open, and (1) if anyone runs into this as blocker please post here and (2) ill keep this in my queue to address sooner or later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants