Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash while managing dictionaries #42

Closed
Bredan80 opened this issue Jan 31, 2023 · 5 comments
Closed

Crash while managing dictionaries #42

Bredan80 opened this issue Jan 31, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@Bredan80
Copy link

Bredan80 commented Jan 31, 2023

Hello.

I've added a few Yomichan/EPWING dicts : here is the list.

Capture

This is probably not exhaustive as I've not tested every combinations, but in this setup I can reproduce the crash (systematically) by trying to move up Daijirin or Daijisen. I can move them as I want as long as I won't try to move them to the 5th position and up from the bottom (position occupied by JMDICT here). Of course, I've tried to remove them and add them up but the crashes occurred again.

As every dict (including Daijirin and Daijisen) are functional nevertheless, I'm using it in this state.

@Bredan80 Bredan80 changed the title Crash when managing dictionnaries Crash while managing dictionnaries Jan 31, 2023
@Bredan80 Bredan80 changed the title Crash while managing dictionnaries Crash while managing dictionaries Jan 31, 2023
@rampaa
Copy link
Owner

rampaa commented Jan 31, 2023

Hi, thanks for reporting this.

Would you mind sharing your dicts.json (located in "...\JL\Config" and the relevant log file (located in "...\JL\Logs")?

@rampaa rampaa added the bug Something isn't working label Jan 31, 2023
@Bredan80
Copy link
Author

Bredan80 commented Jan 31, 2023

Here are the dicts.json and log.

For the json : I've manually edited the file so that the path to JL is changed and changed the extension to txt. The only two particularities of the true path is there is a single space in a parent folder name. and JL is not on the 'c' drive.

For the log : I've closed JL, erased the logs and reproduced the crash, what you get should then directly concern the crash itself.

Also, while I was looking for the log, I noticed two things :

  • I'm getting the warning message [WRN] CopyFromClipboard failed repeated ad nauseam, but JL seems to work properly
  • One of the log (from a previous day) is so full of this warning that the file for this day is 1Gb large... whatever the reason, there should be a limit ^^.

log20230131.txt

dicts.txt

@rampaa
Copy link
Owner

rampaa commented Jan 31, 2023

Thanks for the log/dicts file, the issue will be fixed in the next version of JL.

I'm getting the warning message [WRN] CopyFromClipboard failed repeated ad nauseam, but JL seems to work properly

You can basically ignore that warning. If there's a text in clipboard but JL cannot grab it because the clipboard is blocked in that moment for whatever reason, the aforementioned warning is logged and JL re-tries to get the text until it either succeeds or until clipboard has no text.

One of the log (from a previous day) is so full of this warning that the file for this day is 1Gb large... whatever the reason, there should be a limit ^^.

That's quite bizarre. I'd like to see the file if possible. The biggest log file I got from JL is around 4 MiB. If you are saying "CopyFromClipboard failed" is the sole culprit here, I can just not log that warning I guess.

@Bredan80
Copy link
Author

Bredan80 commented Jan 31, 2023

I've browsed the 1Gb file quickly and failed to notice anything else than the aforementioned warning (although I might have missed something, I don't think I did). Also, I've already deleted the file and would not have uploaded a 1Gb file anyways ^^.

By the way, the log files for the other days were all between 100kb to 1mb : it was the only one out up there.

Thanks for the future bug correction.

@rampaa
Copy link
Owner

rampaa commented Jan 31, 2023

Should be fixed by 32aacd8, e670605 and f8e3ef2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants