Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace std::time::Duration with chrono::Duration to support negative duration #366

Merged
merged 6 commits into from
Dec 27, 2022
Merged

Replace std::time::Duration with chrono::Duration to support negative duration #366

merged 6 commits into from
Dec 27, 2022

Conversation

ramsayleung
Copy link
Owner

@ramsayleung ramsayleung commented Oct 27, 2022 •
edited
Loading

Description

#363

Motivation and Context

#363

Dependencies

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

All existing tests pass.

  • Test A: test_resume_point_negative

Is this change properly documented?

Yes

marioortizmanero
marioortizmanero reviewed Dec 26, 2022
View reviewed changes
Copy link
Collaborator

@marioortizmanero marioortizmanero left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Should we also use it for the parameter in start_context_playback?

@ramsayleung
Copy link
Owner Author

Yes, it makes sense.

@marioortizmanero
Copy link
Collaborator

Nevermind, merging this and adding a few duration-related fixes in a separate PR.

@marioortizmanero marioortizmanero merged commit 1a3a06e into master Dec 27, 2022
@marioortizmanero marioortizmanero deleted the ramsay_fix_negative_progress_ms branch December 27, 2022 13:25
@marioortizmanero marioortizmanero mentioned this pull request Dec 27, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marioortizmanero marioortizmanero marioortizmanero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ramsayleung @marioortizmanero