Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing ETF weights #1554

Closed
lcrmorin opened this issue Jun 9, 2023 · 4 comments
Closed

Missing ETF weights #1554

lcrmorin opened this issue Jun 9, 2023 · 4 comments

Comments

@lcrmorin
Copy link

lcrmorin commented Jun 9, 2023

First of all let me take this opportunity to thank you for greatly improving the time it takes to get ticker info. Some of my code that took 15+ mins to run now run in a minute.

However something else changed in the code. More specifically I was able to get sector weights for ETF. This data seems to still be available on yahoo (see: https://finance.yahoo.com/quote/IVV/holdings?p=IVV, sector weighing). But this info doesn't seems to be available in the info.

Is this an expected change ? Am i missing something ?

@ValueRaider
Copy link
Collaborator

info fetch was completely redone in PRs #1461 and #1480 - converting webpage scraping to API requests.

I had a quick look and fix super-easy, so can I get you to submit a patch to dev branch #1084? It's simply adding 'topHoldings' to modules in quote.py - look at code and should be obvious.

@ValueRaider
Copy link
Collaborator

ValueRaider commented Jun 9, 2023

Also add 'price', this will restore more data. I think there's another issue about this, let me find it ... found it #1518

@AKwoKWH
Copy link

AKwoKWH commented Jun 24, 2023

info fetch was completely redone in PRs #1461 and #1480 - converting webpage scraping to API requests.

I had a quick look and fix super-easy, so can I get you to submit a patch to dev branch #1084? It's simply adding 'topHoldings' to modules in quote.py - look at code and should be obvious.

Not sure if I added the patch correctly.
Can we also have sector/asset class and country allocation of mutual funds?
eg: https://finance.yahoo.com/quote/HGIYX/holdings?p=HGIYX

@AKwoKWH
Copy link

AKwoKWH commented Jun 24, 2023

I further check the codes,
It seems it is getting the page "Holders" instead of "Holdings"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants