Merge pull request #5036 from s0nea/4847

Shorten Kubernetes version label
rancher-sandbox · Jun 26, 2023 · 261f2f9 · 261f2f9
2 parents 4be9501 + 3bc170d
commit 261f2f9
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/pkg/rancher-desktop/assets/translations/en-us.yaml b/pkg/rancher-desktop/assets/translations/en-us.yaml
@@ -166,6 +166,10 @@ suffix:
 app:
   name: Rancher Desktop
   update: "There's one last step to finish updating Rancher Desktop"
+firstRun:
+  kubernetesVersion:
+    legend: Kubernetes Version
+    cachedOnly: (cached versions only)
 marketplace:
   title: Extensions
   noResults: No extension found for the search criteria

diff --git a/pkg/rancher-desktop/pages/FirstRun.vue b/pkg/rancher-desktop/pages/FirstRun.vue
@@ -9,8 +9,9 @@
       :is-locked="kubernetesLocked"
       @input="handleDisableKubernetesCheckbox"
     />
-    <label>
-      Please select a Kubernetes version{{ offlineCheck() }}:
+    <rd-fieldset
+      :legend-text="t('firstRun.kubernetesVersion.legend') + offlineCheck()"
+    >
       <rd-select
         v-model="settings.kubernetes.version"
         :is-locked="kubernetesVersionLocked"
@@ -42,7 +43,7 @@
           </option>
         </optgroup>
       </rd-select>
-    </label>
+    </rd-fieldset>
     <rd-fieldset
       :legend-text="t('containerEngine.label')"
       :is-locked="engineSelectorLocked"
@@ -230,7 +231,7 @@ export default Vue.extend({
       this.$store.dispatch('applicationSettings/setPathManagementStrategy', val);
     },
     offlineCheck() {
-      return this.cachedVersionsOnly ? ' (cached versions only)' : '';
+      return this.cachedVersionsOnly ? ` ${ this.t('firstRun.kubernetesVersion.cachedOnly') }` : '';
     },
   },
 });