From 3bc170dd9190646b830ed34db998ac34316e4728 Mon Sep 17 00:00:00 2001
From: Tatjana Dehler <tdehler@suse.com>
Date: Fri, 23 Jun 2023 15:58:00 +0200
Subject: [PATCH] Shorten Kubernetes version label

Shorten the Kubernetes version label from "Please select a Kubernetes
version" to "Kubernetes Version" to fit better into the form.

Signed-off-by: Tatjana Dehler <tdehler@suse.com>
---
 pkg/rancher-desktop/assets/translations/en-us.yaml | 4 ++++
 pkg/rancher-desktop/pages/FirstRun.vue             | 9 +++++----
 2 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/pkg/rancher-desktop/assets/translations/en-us.yaml b/pkg/rancher-desktop/assets/translations/en-us.yaml
index 589cdf14e44..2a54f38f6b0 100644
--- a/pkg/rancher-desktop/assets/translations/en-us.yaml
+++ b/pkg/rancher-desktop/assets/translations/en-us.yaml
@@ -166,6 +166,10 @@ suffix:
 app:
   name: Rancher Desktop
   update: "There's one last step to finish updating Rancher Desktop"
+firstRun:
+  kubernetesVersion:
+    legend: Kubernetes Version
+    cachedOnly: (cached versions only)
 marketplace:
   title: Extensions
   noResults: No extension found for the search criteria
diff --git a/pkg/rancher-desktop/pages/FirstRun.vue b/pkg/rancher-desktop/pages/FirstRun.vue
index c1e3fd1e02d..f68d68e9e63 100644
--- a/pkg/rancher-desktop/pages/FirstRun.vue
+++ b/pkg/rancher-desktop/pages/FirstRun.vue
@@ -9,8 +9,9 @@
       :is-locked="kubernetesLocked"
       @input="handleDisableKubernetesCheckbox"
     />
-    <label>
-      Please select a Kubernetes version{{ offlineCheck() }}:
+    <rd-fieldset
+      :legend-text="t('firstRun.kubernetesVersion.legend') + offlineCheck()"
+    >
       <rd-select
         v-model="settings.kubernetes.version"
         :is-locked="kubernetesVersionLocked"
@@ -42,7 +43,7 @@
           </option>
         </optgroup>
       </rd-select>
-    </label>
+    </rd-fieldset>
     <rd-fieldset
       :legend-text="t('containerEngine.label')"
       :is-locked="engineSelectorLocked"
@@ -230,7 +231,7 @@ export default Vue.extend({
       this.$store.dispatch('applicationSettings/setPathManagementStrategy', val);
     },
     offlineCheck() {
-      return this.cachedVersionsOnly ? ' (cached versions only)' : '';
+      return this.cachedVersionsOnly ? ` ${ this.t('firstRun.kubernetesVersion.cachedOnly') }` : '';
     },
   },
 });