Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment profile behavior on Windows #4193

Closed
gunamata opened this issue Mar 15, 2023 · 5 comments · Fixed by #4251
Closed

Deployment profile behavior on Windows #4193

gunamata opened this issue Mar 15, 2023 · 5 comments · Fixed by #4251
Labels
kind/bug Something isn't working platform/windows triage/wont-fix This will not be worked on
Milestone

Comments

@gunamata
Copy link
Contributor

The way Windows deployment profile seems to be a bit different from what's intended.

Of the below 2 registry settings, the definition in RD_Phil.txt produces the desired behavior in the app but still requires changes to support broad cases such as WSL Integration etc.. @jandubois , Can you please expand what we discussed and take it from here?

RD_Guna.txt
RD_Phil.txt

@gunamata gunamata added kind/bug Something isn't working platform/windows labels Mar 15, 2023
@gunamata gunamata added this to the 1.8 milestone Mar 15, 2023
@jandubois
Copy link
Member

The implementation doesn't follow the spec from #3750:

Except for maps, all values use the "default value" (lpValueName being the empty string). Maps store the various values under their respective key names.

The current implementation doesn't expect a separate key for each setting, but puts them as a named value under the key one level up.

This will not work for diagnostics.mutedChecks and WSL.integrations because their values are maps with multiple keys, and there is not REG_* data type for multi-value objects (with the exception of REG_MULTI_SZ for a list of strings).

@jandubois
Copy link
Member

Based on the fact that regedit.exe doesn't seem to allow changing the type of the default entry, maybe the current implementation has advantages in usability. So maybe we should adjust the spec instead? Will need to think about it a bit more.

@jandubois
Copy link
Member

So maybe we should adjust the spec instead?

We decided that the current implementation will override the original spec because it has better usability.

@ericpromislow
Copy link
Contributor

There's still more to do:

  1. Verify types of values in the registry conform with types in the schema
  2. Process WSL/integrations, diagnostics/mutedChecks, and extensions as string=>boolean hashes
  3. Complain about unrecognized fields found in the registry, but don't complain about fields in the schema that aren't present in the registry

@ericpromislow
Copy link
Contributor

There's a better issue on this - #4153

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working platform/windows triage/wont-fix This will not be worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants