Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment profiles are ignoring Kubernetes version wrong data type #4952

Closed
Tracked by #4968
IsaSih opened this issue Jun 13, 2023 · 4 comments · Fixed by #5199
Closed
Tracked by #4968

Deployment profiles are ignoring Kubernetes version wrong data type #4952

IsaSih opened this issue Jun 13, 2023 · 4 comments · Fixed by #5199
Assignees
Labels
kind/bug Something isn't working
Milestone

Comments

@IsaSih
Copy link
Contributor

IsaSih commented Jun 13, 2023

Actual Behavior

Once there's a deployment profile with a wrong value for Kubernetes version, Rancher Desktop starts normally, applies the Latest version automatically and does NOT display the Kubernetes version in the UI

Steps to Reproduce

  1. Run a factory-reset
  2. Create a defaults deployment profile specifying Kubernetes version to an invalid value. In this test:
<key>kubernetes</key>
    <dict>
        <key>version</key>
        <string>cre</string>
    </dict> 
  1. Start Rancher Desktop
  2. Check what Kubernetes version is displayed in the Preferences dialog

Result

Rancher Desktop applies the latest Kubernetes version and starts normally instead of throwing an error message. Preferences dialog does not display the corresponding Kubernetes version, and shows and empty field instead
Screen Shot 2023-06-13 at 1 37 10 PM

Expected Behavior

Rancher Desktop must throw an error message and prevent the application to start

Additional Information

No response

Rancher Desktop Version

1.7.0-1684-geb14bb3b

Rancher Desktop K8s Version

1.27.2

Which container engine are you using?

moby (docker cli)

What operating system are you using?

macOS

Operating System / Build Version

macOS Monterey

What CPU architecture are you using?

x64

Linux only: what package format did you use to install Rancher Desktop?

None

Windows User Only

No response

@IsaSih IsaSih added the kind/bug Something isn't working label Jun 13, 2023
@gaktive gaktive added this to the 1.10 milestone Jun 13, 2023
@gaktive
Copy link
Contributor

gaktive commented Jun 26, 2023

Possibly connected (or then a duplicate): #5047

@ericpromislow
Copy link
Contributor

I don't think this needs to be a fatal error. Current behavior is to quietly ignore the proposed version and use the most recent stable version instead.

The change I'm going to make is to write a line to kube.logof the form

Requested kubernetes version X is not a valid version. Falling back to the most recent stable version of Y

and recommend the test looks for this line instead.

@jandubois
Copy link
Member

I don't think this needs to be a fatal error.

It does if the invalid version is specified in a "locked" profile, but I assume #5205 is going to take care of that.

@ericpromislow
Copy link
Contributor

Correct assumption.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants