Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump https-proxy-agent from 5.0.1 to 7.0.1 (or later) #5057

Closed
Nino-K opened this issue Jun 26, 2023 · 4 comments · Fixed by #5214
Closed

Bump https-proxy-agent from 5.0.1 to 7.0.1 (or later) #5057

Nino-K opened this issue Jun 26, 2023 · 4 comments · Fixed by #5214
Assignees
@ericpromislow
Labels
area/proxy kind/quality quality improvements, refactoring, Automation via CI, E2E, Integration, CLI or REST API
Milestone
1.10

Comments

@Nino-K
Copy link
Member

Nino-K commented Jun 26, 2023

In 1.9 we bumped proxy-agent from 5.0.1 to 6.1.0 and that caused some unhandled exceptions on the startup as reported by @byjrack, more details here. This turns out to be a bug with the upstream code and requires a PR to address the issue. I'm creating this issue to keep track of the progress on the PR prior to bumping the proxy-agent again.
@Nino-K Nino-K added kind/bug Something isn't working area/proxy labels Jun 26, 2023
@Nino-K Nino-K added this to the 1.10 milestone Jun 26, 2023
@Nino-K Nino-K self-assigned this Jun 26, 2023
@Nino-K Nino-K removed the kind/bug Something isn't working label Jun 26, 2023
@jandubois jandubois added the kind/quality quality improvements, refactoring, Automation via CI, E2E, Integration, CLI or REST API label Jun 26, 2023
@gaktive gaktive added the triage/blocked Waiting for support from upstream dependency label Jul 6, 2023
@gaktive
Copy link
Contributor

gaktive commented Jul 6, 2023

Waiting for upstream bug fix before re-upgrading.

@byjrack
Copy link

byjrack commented Jul 7, 2023

Hopefully not too far off. TooTallNate/proxy-agents#212

@jandubois jandubois removed the triage/blocked Waiting for support from upstream dependency label Jul 17, 2023
@jandubois
Copy link
Member

The fix has been released in https://github.com/TooTallNate/proxy-agents/releases/tag/https-proxy-agent%407.0.1 a week ago, and is available from npm at https://www.npmjs.com/package/https-proxy-agent/v/7.0.1.

Why is there no dependabot PR to bump it again?

Since we needed to apply additional changes anyways (see e21c9c2), maybe we should just bump manually. But we still need to understand why we are not getting notified automatically: I do see PRs from the weekly npm check, and no exceptions for this package in .github/dependabot.yml.

@jandubois jandubois mentioned this issue Jul 17, 2023
Closed
@jandubois
Copy link
Member

jandubois commented Jul 17, 2023 •
edited
Loading

Why is there no dependabot PR to bump it again?

This is being tracked in #5178. This ticket here is purely about bumping https-proxy-agent to 7.0.1 or later.

@gaktive gaktive changed the title Bump proxy-agent from 5.0.1 to a newer release Bump https-proxy-agent from 5.0.1 to a newer release Jul 21, 2023
@gaktive gaktive changed the title Bump https-proxy-agent from 5.0.1 to a newer release Bump https-proxy-agent from 5.0.1 to 7.0.1 (or later) Jul 21, 2023
@gaktive gaktive assigned ericpromislow and unassigned Nino-K Jul 21, 2023
@gaktive gaktive changed the title Bump https-proxy-agent from 5.0.1 to 7.0.1 (or later) Bump https-proxy-agent from 5.0.1 to 7.0.1 (or later) Jul 21, 2023
@ericpromislow ericpromislow mentioned this issue Jul 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericpromislow ericpromislow

Labels
area/proxy kind/quality quality improvements, refactoring, Automation via CI, E2E, Integration, CLI or REST API
Projects
None yet
Milestone
1.10
Development

Successfully merging a pull request may close this issue.

Bump to https-proxy-agent 7.0.1 and update client code. rancher-sandbox/rancher-desktop
5 participants
@jandubois @ericpromislow @Nino-K @gaktive @byjrack