Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split postinstall.ts into three parts #5127

Closed
ericpromislow opened this issue Jul 7, 2023 · 2 comments · Fixed by #5169
Closed

Split postinstall.ts into three parts #5127

ericpromislow opened this issue Jul 7, 2023 · 2 comments · Fixed by #5169
Assignees
Labels
kind/bug Something isn't working
Milestone

Comments

@ericpromislow
Copy link
Contributor

ericpromislow commented Jul 7, 2023

The Plan

The second part builds the go utils. It doesn't import any node code from @pkg/

The third part is the existing postinstall.ts

The first part is running any code that generates Go files used by the second part, which so far is
scripts/generateCliCode.ts, and its only dependency on the node code is importing
CURRENT_SETTINGS_VERSION from pkg/rancher-desktop/config/settings.ts

Because we can't import pkg/rancher-desktop/config/settings.ts until the Go files are built, the new
postinstall.ts will need a differrent approach to find the value for CURRENT_SETTINGS_VERSION

Try to use dependencies.yaml to keep CURRENT_SETTINGS_VERSION in exactly one place.

@jandubois
Copy link
Member

Try to use dependencies.yaml to keep CURRENT_SETTINGS_VERSION in exactly one place.

Shouldn't the settings version be defined by pkg/rancher-desktop/assets/specs/command-api.yaml?

@ericpromislow
Copy link
Contributor Author

Fixed by #5169

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
2 participants