Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create BATS tests for BATS helper functions #5130

Closed
Tracked by #3026
jandubois opened this issue Jul 7, 2023 · 3 comments
Closed
Tracked by #3026

Create BATS tests for BATS helper functions #5130

jandubois opened this issue Jul 7, 2023 · 3 comments
Assignees
@jandubois
Labels
component/bats BATS tests kind/quality quality improvements, refactoring, Automation via CI, E2E, Integration, CLI or REST API
Milestone
1.10

Comments

@jandubois
Copy link
Member

jandubois commented Jul 7, 2023 •
edited
Loading

Our BATS helper functions have become quite complex. We need to create some kind of unit tests for them, to make sure refactoring the helpers doesn't have unintended effects on our existing tests.
@jandubois jandubois mentioned this issue Jul 7, 2023
Open
8 tasks
@jandubois jandubois self-assigned this Jul 7, 2023
@jandubois jandubois added kind/quality quality improvements, refactoring, Automation via CI, E2E, Integration, CLI or REST API component/bats BATS tests labels Jul 7, 2023
@jandubois jandubois added this to the 1.10 milestone Jul 7, 2023
@jandubois
Copy link
Member Author

#5134 implements unit tests for the current helper functions, but once #4991 is merged we need to add tests for all the profile functions and any other new helper functions added there.

@jandubois
Copy link
Member Author

once #4991 is merged we need to add tests for all the profile functions and any other new helper functions added there.

I've added a separate task for this to the epic, so this issue can be closed once #5134 is merged.

@gaktive
Copy link
Contributor

gaktive commented Jul 31, 2023

Closing this because work is done.

@gaktive gaktive closed this as completed Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jandubois jandubois

Labels
component/bats BATS tests kind/quality quality improvements, refactoring, Automation via CI, E2E, Integration, CLI or REST API
Projects
None yet
Milestone
1.10
Development

No branches or pull requests
2 participants
@jandubois @gaktive