Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait on the backgrounded rdctl process #4975

Closed
wants to merge 1 commit into from
Closed

Conversation

ericpromislow
Copy link
Contributor

Fixes #4517 (although most likely a first draft):

An alternative would be to write the PID for the rdctl bg process to a temp file, and then read it during shutdown and wait if necessary. I'll go there if this PR is on the right track but we don't want to require every single first-test after running rdctl start to call wait_for_rdctl_background_process

@jandubois
Copy link
Member

PR has merge conflicts, and needs to be rebased on main to run the "Spelling" check

- Explicit shutdown is needed on macos after running shells.

Signed-off-by: Eric Promislow <epromislow@suse.com>
@jandubois
Copy link
Member

I don't understand how this PR works.

Does it work on macOS at all? There it just runs /usr/bin/open -a ... and exits; not directly starting a background process, but letting launchd do it. In that case $! is the empty string.

And if rdctl start is really waiting for the child process to exit, how does waiting on the rdctl progress actually if you haven't yet triggered an app shutdown?

@ericpromislow
Copy link
Contributor Author

Not taking this approach. The problem might be solved anyway.

@jandubois jandubois deleted the 4517-wait-on-rdctl branch July 14, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Background rdctl start process on Windows, and look into waiting on it
2 participants