Handle invalid k8s versions at startup #5199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
rak-phillip
reviewed
Jul 21, 2023
Comment on lines
156
to
164
| // If we're here either there's no existing cfg.k8s.version, or it isn't valid | ||
| if (!availableVersions.length) { | ||
| if (currentConfigVersionString) { | ||
| console.log(invalidK8sVersionMainMessage); | ||
| } else { | ||
| console.log('Internal error: no available kubernetes versions found.'); | ||
| } | ||
| throw new Error('No kubernetes version available.'); | ||
| } |
There was a problem hiding this comment.
Do we want to move the check for availableVersions to the beginning of this function? It looks to me like we can't do anything without a collection of avaialableVersions so we'd be able to handle the error case without having to go through the above block first.
There was a problem hiding this comment.
good point. Let's me break two if blocks into one.
This also traps `InvalidVersion` errors when the k8s.version field is invalid or empty. Hard to find because it came out of an `Array.find()` callback method. Invalid versions are logged to kube.log but aren't treated as fatal errors. Signed-off-by: Eric Promislow <epromislow@suse.com>
Signed-off-by: Eric Promislow <epromislow@suse.com>
Signed-off-by: Eric Promislow <epromislow@suse.com>
Signed-off-by: Eric Promislow <epromislow@suse.com>
Signed-off-by: Eric Promislow <epromislow@suse.com>
Keep logging if no-modal-dialogs is specified. Signed-off-by: Eric Promislow <epromislow@suse.com>
Signed-off-by: Eric Promislow <epromislow@suse.com>
ericpromislow
force-pushed
the
4952-handle-invalid-k8s-version
branch
from
b323b91
to
37eb237
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4952
First, the invalid version can come from a deployment profile, the command-line, or be manually written into an existing settings file. All of them are handled the same way.
Currently we quietly change an invalid version to the default k8s version, usually the most recent stable version.
The first change here is to log this change to
kube.log. Also this code was made shared between lima and wsl, so this should all work on Windows.The second change is to prevent mysterious
TypeError: Invalid versionmessages from propagating to a UI dialog box. This was caused byavailableVersions.find(v => v.compare(version) === 0). Ifversionis null, this will throw an uncaughtTypeErrorexception.The third change is to add a bats test to verify this works.