Fix fallback when Kubernetes versions list is unavailable #7515
Conversation
TypeScript can't compute the type of the payload correctly without using a normal discriminated union; this doesn't look as nice, but at least it seems to work. Signed-off-by: Mark Yen <mark.yen@suse.com>
If Rancher Desktop was previously started with a version, but the user wipes the `k3s-versions.json` cache and we fail to download a new copy, handle the error and disable Kubernetes instead of throwing an error. To make sure the user is aware of the issue, also pop a diagnostic to describe the situation. Signed-off-by: Mark Yen <mark.yen@suse.com>
There was a problem hiding this comment.
Thanks, LGTM.
The only issue I have is that the diagnostic doesn't show up right away: I see the bubble with (1) diagnostic, and only when I click on it will it turn into (2) diagnostics: one for being offline, and one for turning of Kubernetes.
If I already open the diagnostics before Kubernetes is being started, then I only see the (1) offline diagnostics. I have to move away and back to the page to see the second one.
I think this is fine, given how rare this situation is, but if it is simple to fix, then maybe do it.
|
I think that's a separate issue about us not refreshing diagnostics in the background at all (though we still execute them); see also #3005. If we fix it the fix would likely be generic. |
If we previously had Kubernetes enabled, then the user deletes the
k3s-versions.jsoncache and we fail to download a new one, we would previously fall over hard. This makes it so we automatically disable Kubernetes in that situation (and add a diagnostic so the user has a chance of figuring out what was wrong).Fixes #7484