-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add availability zones in node pools #21
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needs issue in 2.6 milestone |
1 task
It was reported in rancher/rancher#32960 |
cmurphy
previously approved these changes
Jun 2, 2021
rmweir
previously approved these changes
Jun 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
thedadams
previously approved these changes
Jun 2, 2021
mjura
force-pushed
the
master-az
branch
2 times, most recently
from
June 3, 2021 07:12
4a75db8
to
ee72b03
Compare
cmurphy
previously approved these changes
Jun 3, 2021
thedadams
previously approved these changes
Jun 3, 2021
It was missing AvailabilityZones option in CreateOrUpdateAgentPool
cmurphy
approved these changes
Jun 3, 2021
thedadams
approved these changes
Jun 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was missing AvailabilityZones option in CreateOrUpdateAgentPool
Issue: rancher/rancher#32960