Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add availability zones in node pools #21

Merged
merged 1 commit into from
Jun 3, 2021
Merged

Conversation

mjura
Copy link
Contributor

@mjura mjura commented Jun 2, 2021

It was missing AvailabilityZones option in CreateOrUpdateAgentPool

Issue: rancher/rancher#32960

@mjura mjura requested review from thedadams, rmweir, cmurphy and cbron June 2, 2021 04:51
@cbron
Copy link
Contributor

cbron commented Jun 2, 2021

Needs issue in 2.6 milestone

@mjura
Copy link
Contributor Author

mjura commented Jun 2, 2021

Needs issue in 2.6 milestone

It was reported in rancher/rancher#32960

cmurphy
cmurphy previously approved these changes Jun 2, 2021
rmweir
rmweir previously approved these changes Jun 2, 2021
Copy link
Contributor

@rmweir rmweir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thedadams
thedadams previously approved these changes Jun 2, 2021
@mjura mjura dismissed stale reviews from thedadams, rmweir, and cmurphy via d7504cb June 3, 2021 07:05
@mjura mjura force-pushed the master-az branch 2 times, most recently from 4a75db8 to ee72b03 Compare June 3, 2021 07:12
@mjura mjura requested review from thedadams, rmweir and cmurphy June 3, 2021 07:13
cmurphy
cmurphy previously approved these changes Jun 3, 2021
thedadams
thedadams previously approved these changes Jun 3, 2021
It was missing AvailabilityZones option in CreateOrUpdateAgentPool
@mjura mjura dismissed stale reviews from thedadams and cmurphy via f156b02 June 3, 2021 19:21
@mjura mjura requested review from thedadams and cmurphy June 3, 2021 19:22
@cbron cbron merged commit 0357280 into rancher:master Jun 3, 2021
@mjura mjura deleted the master-az branch July 23, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants