Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust renovate groups & enable cron #494

Merged

Conversation

mallardduck
Copy link
Member

The current settings create really large PRs that mix all types of version bumps (major, minor, etc). And all the contexts (GH actions, docker files, go deps) into the same PR too.

With this change we will technically get more PRs but they will come thru grouped by what feel like safer groups. Since for example in this PR: #493

I wouldn't feel as confident merging the mergo change from v0.3.16 -> v1.0.0. But do feel confident merging the GHA workflow changing from v5 -> v6. So this highlights where 2 major bumps are not equal (cause for concern).

This will allow us to more easily and simply just bump the GHA workflows as we need. Lettings us merge those CI bumps whenever we want. And then any actual bumps that directly go into the code we ship can be scrutinized without delaying those bumps.

@mallardduck mallardduck changed the title Adjust renovate groups Adjust renovate groups & enable cron Jul 19, 2024
@mallardduck
Copy link
Member Author

Here's an example of the PRs we'd expect to see when it runs after this config change:
Screenshot 2024-07-19 at 1 05 40 PM

Copy link
Collaborator

@ericpromislow ericpromislow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't follow everything that's going on here, but from the description it looks worth a try

@mallardduck mallardduck merged commit 5b16353 into rancher:release/v5.0 Jul 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants