Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust how BRO OnBackupChange processes existing complete backups #592

Open
mallardduck opened this issue Oct 3, 2024 · 1 comment
Open

Comments

@mallardduck
Copy link
Member

Describe the bug
During startup of BRO we will see all existing Backups get processed. This is normal, however the current execution path and logging seems to have room for improvement. Specifically it should be clarified better that existing completed backups (specifically one-off) are not actually being reprocessed and taken again. As if they were it would overwrite the existing backup which is bad.

To Reproduce
N/A - to replicate just use BRO, take a few backups, and observe BRO logs when the pods startup.

Expected behavior
We will adjust the execution flow to either:

  • a) return faster for completed one-off backups,
  • b) adjust log message templates to clarify actual results,
  • c) reduce the default verbosity level of some logging.
    Likely a mix of all 3 to find our goldilocks solution.

For option a - we could create a new isSingularAndCompleteBackup (or something) and call it here:
https://github.com/rancher/backup-restore-operator/blob/release/v5.0/pkg/controllers/backup/controller.go#L89

To return even sooner.

Copy link

github-actions bot commented Dec 3, 2024

This repository uses an automated workflow to automatically label issues which have not had any activity (commit/comment/label) for 60 days. This helps us manage the community issues better. If the issue is still relevant, please add a comment to the issue so the workflow can remove the label and we know it is still valid. If it is no longer relevant (or possibly fixed in the latest release), the workflow will automatically close the issue in 14 days. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant