Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

omit DWARF debug info when building BRO binaries #625

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alexandreLamarre
Copy link
Contributor

No description provided.

Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com>
@alexandreLamarre alexandreLamarre changed the base branch from main to release/v6.0 December 5, 2024 15:30
@mallardduck
Copy link
Member

mallardduck commented Dec 9, 2024

Will want to have this target main and then you can use /backport {branch} {milestone: optional} to have GHA create backport PRs. Or you can manually create backport PRs too obviously.

@alexandreLamarre alexandreLamarre changed the base branch from release/v6.0 to main December 11, 2024 17:06
@alexandreLamarre
Copy link
Contributor Author

/backport release/v6.0

@alexandreLamarre alexandreLamarre marked this pull request as ready for review December 11, 2024 17:07
@alexandreLamarre alexandreLamarre requested a review from a team as a code owner December 11, 2024 17:07
@mallardduck
Copy link
Member

mallardduck commented Dec 12, 2024

Hmm. Odd - looks like the backport action failed because it doesn't identify you as a member of rancher org. 🤔 Seems odd, maybe an Okta profile issue? AFAIK if our SUSE okta has our GitHub username in the profile it will auto add/invite us to Rancher org.

Also BTW @jbiers and I opted to start using 6.x for the branch name since it's more accurate than using zero.

@rancher rancher deleted a comment from github-actions bot Dec 12, 2024
@rancher rancher deleted a comment from github-actions bot Dec 12, 2024
@mallardduck
Copy link
Member

/backport release/v6.x

@mallardduck
Copy link
Member

mallardduck commented Dec 12, 2024

@alexandreLamarre - seems the backport command should work as intended now.

At least barring permission issues:

alexandreLamarre is not a member of rancher

As mentioned you may just need to adjust Okta settings to ensure your user shows up as in the Rancher org - if you are in the org, I think your membership needs to be public for it work. So that could be a factor too if you're in the org currently. If possible maybe we can create a workaround for that to allow that membership to stay private and still be identifiable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants