Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport release/v5.0] Add integration tests for arm64 #562

Closed
wants to merge 1 commit into from

Conversation

github-actions[bot]
Copy link

This is an automated request to port PR #555 by @mallardduck

Original PR body:

Signed-off-by: Dharmit Shah <dharmit.shah@suse.com>
@github-actions github-actions bot requested a review from a team as a code owner August 20, 2024 17:55
@mallardduck
Copy link
Member

@dharmit - before we review this backport and merge it, I just had the thought that I should wait until the merge to main CI completes at the very least. And maybe I would even take a deeper dive in the current CI workflows involved here and the scripts - it's been too long since the last time I took a deep look here.

@dharmit
Copy link
Contributor

dharmit commented Aug 21, 2024

I should wait until the merge to main CI completes at the very least.

IIUC, it's failing.

@mallardduck
Copy link
Member

Looking into the failure a bit today. I suspect we can fix with more CI changes on GHA side, or potentially via adjustments to our scripts/ files.

TBH, I think this warrants me taking a deeper dive into CI stuff, since our ideal would be that we have easy methods to run everything locally in a similar way to the GHA stuff. However that will take time and shouldn't distract from our immediate issue.

I will spend tomorrow working on a simple fix for this build issue. I think we can try a simple "hack" like the other one I have in place for container image tags.

But big picture I will document for us a roadmap to get our CI fully embracing the new branching strategy. That way we will have proper head builds for release branches and main - built with both a static tag and a rolling -head tag.

@mallardduck
Copy link
Member

Given that we will need to make changes to main I'll close this out and we'll manually backport.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants