Cleanup dapper and code #626
Conversation
Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com>
Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com>
Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com>
Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com>
Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com>
Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com>
Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com>
Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com>
Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com>
Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com>
Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com>
Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com>
Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com>
Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com>
Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com>
Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com>
Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com>
alexandreLamarre
force-pushed
the
cleanup
branch
from
450e8fb to
615ce2e
Compare
| @@ -135,7 +146,7 @@ func GetS3Client(ctx context.Context, objectStore *v1.S3ObjectStore, dynamicClie | |||
| log.Tracef("Found secretKey [%s] in secret [%s] in namespace [%s]", secretKey, secretName, secretNs) | |||
| } | |||
| // if no s3 credentials are provided, use IAM profile, this means passing empty access and secret keys to the SetS3Service call | |||
| s3Client, err := SetS3Service(objectStore, accessKey, secretKey, true) | |||
| s3Client, err := SetS3Service(objectStore, accessKey, secretKey, false) | |||
There was a problem hiding this comment.
Need to inject an additional option when storing secrets to set SSL to false, but always safeguard to defaulting to true unless explicitly opted out of
.github/workflows/ci.yaml
Outdated
There was a problem hiding this comment.
Need to update goreleaser and release CI as well
Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com>
alexandreLamarre
force-pushed
the
cleanup
branch
from
8072b71 to
baec5da
Compare
Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com>
Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com>
Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com>
alexandreLamarre
force-pushed
the
cleanup
branch
from
74f21a3 to
010f271
Compare
There was a problem hiding this comment.
Seems there's an existing bug with this RE image tags.
The issue comes from the script/version file though.
The tag appended to the image will have a suffix set based on the CPU arch. So even when you opt to use buildx - which currently produces only amd64 but could really produce a multiarch - will have the CPU suffix of the native arch, not the target arch.
I think a simple fix is just to fully remove that aspect of the scripts. Since it's not needed for real image releases (as those directly build the Dockerfile), nor is it really helpful for dev usage IMO.
There was a problem hiding this comment.
yeah good catch hadn't paid much attention to that part
No description provided.