Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Change Sub-Menu name to CAPIProviders #44

Closed
cpinjani opened this issue Apr 15, 2024 · 1 comment · Fixed by #50
Closed

[BUG] Change Sub-Menu name to CAPIProviders #44

cpinjani opened this issue Apr 15, 2024 · 1 comment · Fixed by #50
Assignees
Labels
area/ui kind/bug Something isn't working

Comments

@cpinjani
Copy link
Collaborator

cpinjani commented Apr 15, 2024

Setup
Rancher version: v2.8-head
Rancher Turtles: v0.6.0
Rancher UI Extensions: CAPI UI Extension v0.4.0
Browser type & version: Chrome Latest

To Reproduce

  • Install CAPI UI extension
  • Open Cluster Management > CAPI Menu
  • Check Infrastructure Providers

Expected Result
With new enhancement #13, it seems all providers are now being listed which are of type capiproviders, so we can change Menu name to denote providers appropriately

$ kubectl get capiproviders -A
NAMESPACE                           NAME                    TYPE             PROVIDERNAME   INSTALLEDVERSION   PHASE
capd-system                         docker                  infrastructure   docker         v1.4.6             Ready
capi-kubeadm-bootstrap-system       kubeadm-bootstrap       bootstrap        kubeadm        v1.4.6             Ready
capi-kubeadm-control-plane-system   kubeadm-control-plane   controlPlane     kubeadm        v1.4.6             Ready
capi-system                         cluster-api             core             cluster-api    v1.4.6             Ready
rke2-bootstrap-system               rke2-bootstrap          bootstrap        rke2           v0.2.6             Ready
rke2-control-plane-system           rke2-control-plane      controlPlane     rke2           v0.2.6             Ready

In previous versions only infra providers used to listed:

$ kubectl get infrastructureproviders -A
NAMESPACE     NAME     INSTALLEDVERSION   READY
capd-system   docker   v1.4.6             True

Screenshots
image

cc: @richardcase

@eva-vashkevich
Copy link
Member

I've checked with Ken and we decided to rename CAPI Clusters to Clusters and Infrastructure providers to Providers for better consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui kind/bug Something isn't working
Development

Successfully merging a pull request may close this issue.

3 participants