fix: make the cli runnable on windows #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guilherme Macedo <guilherme@gmacedo.com>
Bump Go and Dockerfile versions
Signed-off-by: Guilherme Macedo <guilherme@gmacedo.com>
[v2.7] Update saml auth login endpoint to point toward dashboard endpoint
|
👋 @bakito Thanks for raising this PR, and apologies for the long delay in any response. If you're still willing, I'd be happy to work with you to get this PR into shape so it can be merged. My only concern being the use of If you could update this PR so that it no longer uses |
Signed-off-by: bakito <github@bakito.ch>
|
This should do the trick. |
HarrisonWAffel
previously approved these changes
Dec 7, 2023
HarrisonWAffel
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As as already mentioned in #306, the cli is not running properly in windows, as the parent dir of the config file is not evaluated correctly.
This PR fixes this and uses also
os.UserHomeDir()to evaluate the home dir of the user instead of just expanding the HOME variable.