Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2.9] Migrate from Drone to Github Actions, remove Dapper and add Darwin/arm64 support #362

Merged
merged 10 commits into from
May 6, 2024

Conversation

enrichman
Copy link
Contributor

@enrichman enrichman commented Apr 19, 2024

This PR migrates the CI to Drone to GitHub Actions. It also removes dapper.

Secrets were already migrated and tested with #365.

In order to use the golangci/golangci-lint-action the validate script was changed to skip the linting, and a dedicated lint script was added.

As a bonus the arm64 arch was added to the Darwin build (OS_ARCH_ARG[darwin]="amd64 arm64" ), this will fix #329 .

@enrichman enrichman force-pushed the 44987-v2.9-gha-migration branch 3 times, most recently from 78779de to cdf0e6c Compare April 29, 2024 11:09
@enrichman enrichman changed the title [WIP] 44987 v2.9 gha migration [v2.9] Migrate from Drone to Github Actions, remove Dapper and add Darwin/arm64 support Apr 29, 2024
@enrichman enrichman marked this pull request as ready for review April 29, 2024 14:13
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
- removed extra Test step
- added check for run on PRs
- added FOSSA check on release
@enrichman enrichman linked an issue Apr 30, 2024 that may be closed by this pull request
Copy link
Contributor

@crobby crobby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a GHA expert yet, but nothing seems horribly out of place. lgtm

@enrichman enrichman merged commit 192a95e into rancher:v2.9 May 6, 2024
1 check passed
enrichman added a commit to enrichman/cli that referenced this pull request May 6, 2024
enrichman added a commit that referenced this pull request May 23, 2024
…and add Darwin/arm64 support (#366)

* backport of #362

* avoid recursive find and inclusion of sha256sum.txt file in shasum

* added contents write permission to publish assets in release

* added comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate rancher/cli from Drone to GH Actions
4 participants