Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2.9] add codeowners file #369

Merged
merged 1 commit into from
May 24, 2024
Merged

Conversation

JonCrowther
Copy link
Contributor

Add the collie team as the codeowner of rancher/cli

@JonCrowther JonCrowther self-assigned this May 23, 2024
@JonCrowther JonCrowther changed the title add codeowners file [v2.9] add codeowners file May 23, 2024
Copy link
Contributor

@enrichman enrichman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shows an error to me:

image

Do we need to make the team public? It seems already the case, but not sure why it fails then.

I'm approving because the @rancher/collie tag seems to work, so... 🤷

image

@JonCrowther
Copy link
Contributor Author

@enrichman the error was because the team did not have write access to the repository. The EIO team has fixed that for us and now github is saying the file is valid 😄

@JonCrowther JonCrowther merged commit 902726c into rancher:v2.9 May 24, 2024
1 check passed
@JonCrowther JonCrowther deleted the 2.9-add-codeowners branch May 24, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants