Fix panic on context switch
#386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enrichman
changed the title
context switch45340 rancher cli panicscontext switch
pmatseykanets
approved these changes
Aug 22, 2024
|
Yes, I agree. Not sure if having those just at the Next week there will be a discussion about the CLI, so if we will need to develop a bit more on it then we will have some time to clean up the code! |
alegrey91
approved these changes
Aug 22, 2024
enrichman
added a commit
to enrichman/cli
that referenced
this pull request
Aug 22, 2024
* added bool check for missing focused server, fixed panic * added main branch to FOSSA workflow * return error instead of bool
enrichman
added a commit
to enrichman/cli
that referenced
this pull request
Sep 4, 2024
* added bool check for missing focused server, fixed panic * added main branch to FOSSA workflow * return error instead of bool
enrichman
added a commit
that referenced
this pull request
Sep 4, 2024
* added bool check for missing focused server, fixed panic * added main branch to FOSSA workflow * return error instead of bool
enrichman
added a commit
that referenced
this pull request
Sep 4, 2024
* added bool check for missing focused server, fixed panic * added main branch to FOSSA workflow * return error instead of bool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: rancher/rancher#45340
Switching an empty context will cause a panic.
Added an
ErrNoServerSelectederror on theFocusedServer()func to force the check of a valid focused server.