-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[e2e] Test have been failing for a long time #242
Comments
@furkatgofurov7 To fix this we need to fix #263. I propose to do this in a separate PR and merge #260 as is, as it resolves contract issue. |
Also, kubernetes-sigs/cluster-api#9952 seems to be required here too. |
@richardcase I think this was closed by mistake. e2e tests are not passing with this merged change alone for me. |
They passed for me this morning |
@furkatgofurov7 You mentioned there is an issue with the e2e tests, later in the run. Can you give more details? I’ll retry on my side as well. In my setup I was hitting originally this issue: #263 |
Maybe this is now hinting an environmental factors. I will run it in different environments to check. I also created #267 so we can run the e2e via self hosted runners, to test. |
It was running in my fork, re-running it again to test the latest changes https://github.com/furkatgofurov7/cluster-api-provider-rke2/actions/runs/7958544104/job/21723628664 |
I see the job is passing green. It looks like it is environment specific in some way: https://github.com/rancher-sandbox/cluster-api-provider-rke2/actions/runs/7958280349 |
Passed in my fork as well: https://github.com/furkatgofurov7/cluster-api-provider-rke2/actions/runs/7958544104 |
What happened:
Our nightly e2e test have been failing for a long time now.
What did you expect to happen:
The tests to pass consistently
How to reproduce it:
Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
Environment:
/etc/os-release
):The text was updated successfully, but these errors were encountered: